Fix(tokenizer): don't increment array cursor by 2 on CRLF

[georgesittas]

Fixes #3200

We used to increment i by 2 inside _advance, in order to basically skip the \r\n sequence and have the line attribute be automatically updated to the right value. However, this didn't take into account an edge case where the SQL string can end in \r\n and so it resulted in an off-by-one index error, as reported in the linked issue.

Since the original motivation for this change was to fix the line attribute, which was getting incremented twice for every \r\n sequence, I changed our approach to simply not increment it when we find the \r in the sequence and only do it on the subsequent \n.

[mr-miles]

It's totally immaterial but I noticed the column gets set to 1 but the line number doesnt change til the next iteration ... how about

            if not(self._char == "\r" and self._peek == "\n"):
               self._col = 1
               self._line += 1

anyhow thanks for the swift attention!

[georgesittas]

It's totally immaterial but I noticed the column gets set to 1 but the line number doesnt change til the next iteration ... how about

            if not(self._char == "\r" and self._peek == "\n"):
               self._col = 1
               self._line += 1

anyhow thanks for the swift attention!

Done, thanks! I liked this approach more, I think it simplifies the logic 👍