Feat(prql): Handle DESC with sort #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
Apr 11, 2024
| @@ -5,56 +5,56 @@ class TestPRQL(Validator): | |||
| dialect = "prql" | |||
|
|
|||
| def test_prql(self): | |||
| self.validate_identity("FROM x", "SELECT * FROM x") | |||
There was a problem hiding this comment.
Btw, it also seems that PRQL's keywords are case-sensitive. So
FROM xis not valid, butfrom xis. You can use their playground environment to check these things:
PRQL keyword are case sensitive so I just lowercase all of them, and check whether they're valid in the playground
georgesittas
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.