Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(trino): bring back TRIM parsing #3385

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix(trino): bring back TRIM parsing #3385

merged 1 commit into from
Apr 30, 2024

Conversation

georgesittas
Copy link
Collaborator

Fixes #3384

Seems like the TRIM parser was removed from Presto in 57eb2ce9c. Presto doesn't seem to like the non-CSV syntax:

presto> SELECT TRIM('!' FROM '!foo!');
Query 20240430_215821_00000_x3v83 failed: line 1:17: mismatched input 'FROM'. Expecting: ',', <expression>
SELECT TRIM('!' FROM '!foo!')

But Trino does.

References:

@georgesittas georgesittas merged commit 477754c into main Apr 30, 2024
5 checks passed
@georgesittas georgesittas deleted the jo/trim_trino branch April 30, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't parse trim in TrinoSQL
2 participants