Fix: handle empty string in connector comment padding #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add a test case |
georgesittas
reviewed
May 9, 2024
tests/test_generator.py
Outdated
Comment on lines
48
to
55
| def test_pad_comment(self): | ||
| self.assertEqual(Generator().pad_comment(""), "") | ||
| self.assertEqual(Generator().pad_comment(" leading"), " leading ") | ||
| self.assertEqual(Generator().pad_comment("trailing "), " trailing ") | ||
| self.assertEqual( | ||
| Generator().pad_comment(" leading and trailing "), " leading and trailing " | ||
| ) | ||
| self.assertEqual(Generator().pad_comment("no padding"), " no padding ") |
There was a problem hiding this comment.
Can we instead test this end-to-end by simply adding an example that fails to roundtrip in pretty.sql?
georgesittas
reviewed
May 9, 2024
georgesittas
changed the title
|
hm it seems that if moving the check if comment is empty str/None to the method will still cause some issues for some tests:
select x, --
from foo""",
Maybe it's better to add a check to connector_sql and in maybe_comment? I see it's validated like this everywhere else ( if comment: |
|
TL;DR: Revert my changes in the first place and add if comment check in connector_sql: if comment:
op += f" /*{self.pad_comment(comment)}*/" |
|
Sure let's do that |
georgesittas
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
if comment is an empty string pad_comment fails on IndexError on comment[0]. Adding a simple check if comment is not empty