fix: func to binary MOD generation #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3431
Dialects such as Trino support both
MOD(a, b)anda % brepresentations of the modulo operation. Until now, the generation from the former to the latter would happen as is, which is incorrect for non-leaf operations; For example, the function call has the following semantics:MOD(8 - 1 + 7, 7) == (8 - 1 + 7) % 7 == 0But is generated to the following flat expression:
8 - 1 + 7 % 7 == 8 - 1 + (7 % 7) == 7To solve this issue, when parsing a
MOD(...)function call, the LHS is wrapped if it's a series of binary expressions i.e adds, subs etc, otherwise it remains as-is (case of single literals, nested function calls, columns etc).