-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clickhouse): add support for ALTER TABLE REPLACE PARTITION statement #3441
feat(clickhouse): add support for ALTER TABLE REPLACE PARTITION statement #3441
Conversation
…ment Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
Thanks for the PRs and for the responsive iterations @GaliFFun ! By looking at the Clickhouse docs, it seems that there's a long list of partition-related Also, for the |
@VaggelisD this seems like a good idea. The reason I used the current approach is the existence of |
The As for the specialized vs catch-all expressions, no matter the approach I think it still be good to limit the scope of each PR (as you've done already), so don't feel pressured to add everything in at once right away. Let's wait until others chime in on this issue |
We can refactor this approach in a followup PR to avoid scope creep. I like Vaggelis' idea, let's see if we can avoid having to add all these new expression types for each of these |
Added support for ClickHouse ALTER TABLE REPLACE PARTITION, which is very useful in ETL processes (which my company analyzes using sqlglot). ON CLUSTER support isn't there yet, willing to do that in the near future.
Doc reference:
https://clickhouse.com/docs/en/sql-reference/statements/alter/partition#replace-partition