-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snowflake): COPY Subquery postfix #3449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
May 10, 2024
tobymao
reviewed
May 10, 2024
tobymao
reviewed
May 10, 2024
tobymao
approved these changes
May 10, 2024
georgesittas
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the comments 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3434
This PR addresses the following issues:
COPY would only allow files in the
FROM
clause, extend it to allow subqueries as wellWhen parsing staged files such as
@foo
we'd also consume the following parentheses coming from (optional) staged file options such asSELECT * FROM @foo (FILE_FORMAT => ...)
. However, if there are no options specified we would end up consuming any followingR_PAREN
as well e.g.SELECT * FROM (SELECT * FROM @foo)
For transforming semi-structured data Snowflake specifies the subquery columns as
[<alias>.]$<file_col_num>[.<element>]
. However, the tokenizer always appends theTokenType.DOT
to following a number e.g.$1.elem -> $1.e lem
. To solve this issue, the tokenizer will only parse an integer (and not a real) if the number is prefixed by a token of typeTokenType.PARAMETER
The base parser parses
exp.Parameter
as'[' <this> ':' <expression> ']'
but only generatesthis
. Snowflake parsers$<num>
asexp.Parameter
which can optionally be followed by a path & element name such as$1:a.c
. For this reason,exp.Parameter
now generates<this> [':' <expression>]
Docs