feat(spark, databricks)!: Support for DATE_ADD functions #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
approved these changes
Jun 6, 2024
|
what happens with spark 3.4? |
|
@tobymao The new |
|
you need to make sure it’s not default so that 3.4 still works |
VaggelisD
changed the title
georgesittas
reviewed
Jun 6, 2024
georgesittas
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3607
Until now Hive and it's child dialects supported
DATE_ADD(startDate, numDays)which had "hardcoded" the unit toDAYSand returned aDATE.Spark3 (testing on 3.5.1) and Databricks have introduced support for
DATE_ADD(unit, value, expr)(alias ofTIMESTAMPADDandDATEADD) which instead returns aTIMESTAMP.Note that the old / 2-arg version is still supported alongside the new one and should be preserved to ensure the
DATEvsTIMESTAMPsemantics.