Imix app: dont print error for enoack #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded: |
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
85: Imix app: dont print error for enoack r=ppannuto a=hudson-ayers Currently, the Imix test app will print `Error sending packet -13` if a receiving device is not also active nearby and acking packets sent by the sender. This is a result of the 15.4 stack now correctly returning ENOACK when packets are transmitted successfully but not Acked (tock/tock#758). This PR fixes the Imix app to not indicate an error if TOCK_ENOACK is returned when sending a 15.4 packet. It also removes the "kernel" comment to reflect that LED(0) is no longer the led labeled "kernel" as that LED is no longer accessible from userspace. Co-authored-by: Hudson Ayers <hayers@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Imix test app will print
Error sending packet -13if a receiving device is not also active nearby and acking packets sent by the sender. This is a result of the 15.4 stack now correctly returning ENOACK when packets are transmitted successfully but not Acked (tock/tock#758).This PR fixes the Imix app to not indicate an error if TOCK_ENOACK is returned when sending a 15.4 packet.
It also removes the "kernel" comment to reflect that LED(0) is no longer the led labeled "kernel" as that LED is no longer accessible from userspace.