Remove unused feature declarations #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Jun 25, 2018
chips/nrf52/src/lib.rs
Outdated
| #![feature( | ||
| asm, concat_idents, const_fn, const_cell_new, try_from, core_intrinsics, iterator_step_by | ||
| )] | ||
| #![feature(asm, const_fn, core_intrinsics, iterator_step_by)] |
There was a problem hiding this comment.
Is not step_by is stabilized now?
There was a problem hiding this comment.
Not with this nightly, but I can try on a new nightly.
There was a problem hiding this comment.
Sorry, looked at the wrong release will definitely be in 1.28.0 but it was merged 23 days ago and should be available soon I guess!
niklasad1
previously approved these changes
Jun 26, 2018
niklasad1
added
needs-rebase
P-Upkeep
alevy
previously approved these changes
Jun 26, 2018
bradjc
force-pushed
the
remove-unneeded-features
branch
from
a543b3f
to
7055b69
Compare
ppannuto
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request cleans up some
#![feature()]declarations that are not needed.Testing Strategy
This pull request was tested by compiling, but travis will be a good check.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.