-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add I2C slave support for nRF #2619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/i2c-2
branch
2 times, most recently
from
June 14, 2021 07:37
a5d5bb5
to
9f77941
Compare
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/i2c-2
branch
from
June 14, 2021 08:34
9f77941
to
1566a41
Compare
hudson-ayers
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though one question about a buffer change in capsules
bors bot
added a commit
to tock/libtock-c
that referenced
this pull request
Jun 16, 2021
214: libtock/i2c_master_slave: Add ReadOnly buffer support r=ppannuto a=alistair23 This requires tock/tock#2619 Signed-off-by: Alistair Francis <alistair.francis@wdc.com> Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
This is ready to go |
bradjc
approved these changes
Jun 21, 2021
bors r+ |
bors bot
added a commit
to tock/libtock-c
that referenced
this pull request
Jun 23, 2021
214: libtock/i2c_master_slave: Add ReadOnly buffer support r=alistair23 a=alistair23 This requires tock/tock#2619 Signed-off-by: Alistair Francis <alistair.francis@wdc.com> Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
214: libtock/i2c_master_slave: Add ReadOnly buffer support r=alistair23 a=alistair23 This requires tock/tock#2619 Signed-off-by: Alistair Francis <alistair.francis@wdc.com> Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This builds on top of #2612 by adding nRF I2C
master_slave_driver
support.Testing Strategy
Running I2C communication on the nRF
TODO or Help Wanted
Nothing
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.