Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common_regs] #[repr(packed)] is unsafe since a while go #772

Merged
merged 1 commit into from Mar 5, 2018
Merged

[common_regs] #[repr(packed)] is unsafe since a while go #772

merged 1 commit into from Mar 5, 2018

Conversation

niklasad1
Copy link
Member

#[repr(C, packed)] -> #[repr[C]

@niklasad1
Packed is unsafe since a while go
4fe753a 
#[repr(C, packed)] -> #[repr[C]
@ppannuto ppannuto added documentation P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. labels Mar 5, 2018
@ppannuto ppannuto merged commit 8ec4146 into master Mar 5, 2018
@ppannuto ppannuto deleted the niklasad1-registers branch March 5, 2018 00:09
@brghena
Copy link
Contributor

brghena commented Mar 5, 2018

Hey, was this tested at all? Maybe I'm being to worried about nothing, but I'm always concerned that removing packed might screw something up.

@ppannuto
Copy link
Member

ppannuto commented Mar 5, 2018

This only changed the README to match the code. The packed removal changed ~a month ago with the last rust version bump

@brghena
Copy link
Contributor

brghena commented Mar 5, 2018

Ooh, I didn't see that this was in a README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppannuto ppannuto ppannuto approved these changes

Assignees
No one assigned
Labels
documentation P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niklasad1 @brghena @ppannuto