Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capsules: add analog_sensors.rs #1040

Closed
wants to merge 1 commit into from

Conversation

@bradjc
Copy link
Contributor

commented Jun 27, 2018

This is a capsule that provides the sensor HILs for simple analog sensors that only require a single ADC pin.

Blocked on ADC HIL updates.

Testing Strategy

Todo. My plan is test things on the ADC when everything isn't in a thousand separate branches.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@bradjc bradjc added the blocked label Jun 27, 2018

@bradjc bradjc force-pushed the analog-sensor-capsule branch from 25c9ca4 to 9a5f801 Jul 6, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2018

I updated this with the changes to the ADC HIL, but I still need to test it on actual hardware.

/// Callbacks from the ADC driver
impl<A: hil::adc::Adc> hil::adc::Client for AnalogLightSensor<'a, A> {
fn sample_ready(&self, sample: u16) {
// TODO: calculate the actual light reading.

This comment has been minimized.

Copy link
@alevy

alevy Jul 7, 2018

Member

Are these TODOs the things that are blocking on the ADC HIL PR?

This comment has been minimized.

Copy link
@bradjc

bradjc Jul 9, 2018

Author Contributor

They were, but now they are blocking on testing.

capsules: add analog_sensors.rs
This is a capsule that provides the sensor HILs for simple analog
sensors that only require a single ADC pin.

@bradjc bradjc force-pushed the analog-sensor-capsule branch from 9a5f801 to 35e2877 Dec 6, 2018

@bradjc bradjc closed this Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.