capsules: add analog_sensors.rs #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
added
the
blocked
bradjc
force-pushed
the
analog-sensor-capsule
branch
from
25c9ca4
to
9a5f801
Compare
|
I updated this with the changes to the ADC HIL, but I still need to test it on actual hardware. |
alevy
reviewed
Jul 7, 2018
| /// Callbacks from the ADC driver | ||
| impl<A: hil::adc::Adc> hil::adc::Client for AnalogLightSensor<'a, A> { | ||
| fn sample_ready(&self, sample: u16) { | ||
| // TODO: calculate the actual light reading. |
There was a problem hiding this comment.
Are these TODOs the things that are blocking on the ADC HIL PR?
There was a problem hiding this comment.
They were, but now they are blocking on testing.
This is a capsule that provides the sensor HILs for simple analog sensors that only require a single ADC pin.
bradjc
force-pushed
the
analog-sensor-capsule
branch
from
9a5f801
to
35e2877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a capsule that provides the sensor HILs for simple analog sensors that only require a single ADC pin.
Blocked on ADC HIL updates.
Testing Strategy
Todo. My plan is test things on the ADC when everything isn't in a thousand separate branches.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.