tools: update makefile to partition CI #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eases running the failing portions of CI locally
|
Added bonus: Cargo is smart enough to lock build directories when needed, so parallel builds also seem to work. On my laptop, after an already successful run (i.e. everything already built): |
jrvanwhy
previously approved these changes
Apr 24, 2020
gendx
reviewed
Apr 24, 2020
Also add a comment explaining what these are and why we build this way.
ppannuto
force-pushed
the
split-up-ci-rules
branch
from
382c3d2
to
d94e950
Compare
gendx
approved these changes
Apr 24, 2020
alistair23
approved these changes
Apr 24, 2020
hudson-ayers
approved these changes
Apr 27, 2020
lschuermann
approved these changes
Apr 28, 2020
|
bors r+ |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eases running the failing portions of CI locally
Pull Request Overview
Inspired by moving rules around while working on #1512, this partitions each phase of CI into its own rule. It should effectively be a no-op.
Testing Strategy
This pull request was tested by making my poor laptop very warm by running lots of
make ci-XTODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.