Add a git-diff line to tools/post_size_changes_to_github.sh #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nderstand where size differences come from.
hudson-ayers
approved these changes
Apr 27, 2020
|
Should this be merged or is it superseded by the GitHub workflows? |
|
I think this should still be merged as long as we are still using Travis, once we move away from Travis this file will be deleted. But it is nice to have the info in both places for now. |
hudson-ayers
added
the
P-Upkeep
|
bors d+ |
|
✌️ gendx can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
I noticed that the size diffing tool has been added back in #1753. However, I find it hard to pinpoint which sections of the code have the most impact in the size difference, because the diff only summarizes global flash and RAM differences.
However, the size reports are more detailed than that.
This pull request adds a simple
git diffcommand over the raw size reports. Although it doesn't compute the difference as a number or percentage, it's a low-hanging fruit which can help understanding where the difference comes from.Testing Strategy
This pull request was tested by Travis.
TODO or Help Wanted
tools/diff_memory_usage.pyinstead?Documentation Updated
/docs, or no updates are required.Formatting
make formatall.