Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert QEMU testing to use rexpect #1832

Merged
merged 2 commits into from May 12, 2020
Merged

Convert QEMU testing to use rexpect #1832

merged 2 commits into from May 12, 2020

Conversation

alistair23
Copy link
Contributor

Pull Request Overview

Convert the QEMU CI testing from greping logs to using the Rust port of pexpect (rexpect).

This gives us much more control for interfacing with Tock and QEMU during testing.

This is part of the overall push for QEMU tests, see: #1827

Testing Strategy

Use the Makefile to run the tests.

TODO or Help Wanted

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@alistair23
qemu-runner: Initial commit of qemu-runner
7706f90 
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23
Makefile: Use the new qemu-runner for emulation-check
cb2e3cd 
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23 alistair23 added the WG-OpenTitan In the purview of the OpenTitan working group. label May 6, 2020
@alistair23 alistair23 changed the title Convert QEMU testing use rexpect Convert QEMU testing to use rexpect May 6, 2020
bradjc
bradjc approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually it would be nice to have the actual test in some sort of tests folder, but this is a good step for now.

@hudson-ayers hudson-ayers added the last-call Final review period for a pull request. label May 11, 2020
@bradjc
Copy link
Contributor

bradjc commented May 12, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 12, 2020

Build succeeded:

@bors bors bot merged commit 87f9e04 into tock:master May 12, 2020
@alistair23 alistair23 deleted the alistair/qemu-runner branch May 12, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradjc bradjc bradjc approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
last-call Final review period for a pull request. WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alistair23 @bradjc @hudson-ayers