Added init() function to stm32f4 crates #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
previously approved these changes
May 8, 2020
|
Can we remove tock/chips/stm32f429zi/src/lib.rs Line 3 in d958392 as part of this as well? That would help add some level of enforcement to this. |
|
Done |
bradjc
reviewed
May 8, 2020
Co-authored-by: Brad Campbell <bradjc5@gmail.com>
bradjc
previously approved these changes
May 8, 2020
hudson-ayers
previously approved these changes
May 9, 2020
ppannuto
requested changes
May 11, 2020
Co-authored-by: Pat Pannuto <pat.pannuto@gmail.com>
alexandruradovici
dismissed stale reviews from hudson-ayers and bradjc
via
23171fe
hudson-ayers
approved these changes
May 11, 2020
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request:
initfunction to the stm32f4 sub crates so that the object file is not ignored by the compiler and IRQS are included in the .irqs sectionThis fixes #1835.
It seems to be related to rust-lang/rust#56639.
Testing Strategy
This pull request was tested with a nucleo429zi board.
TODO or Help Wanted
Documentation Updated
Formatting
make formatall.