Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTitan: HMAC: Convert to being interrupt driven #1840

Merged
merged 3 commits into from May 14, 2020

Conversation

alistair23
Copy link
Contributor

Pull Request Overview

Convert the OpenTitan HMAC to being interrupt driven. When the MSF_FIFO buffer is not empty or full we stop writing to it and wait for it to become empty.

Testing Strategy

Running OpenTitan HMAC example on the FPGA.

TODO or Help Wanted

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
When the HMAC MSG_FIFO register is not empty stop writing to it and wait
for it to be empty again.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23 alistair23 added the WG-OpenTitan In the purview of the OpenTitan working group. label May 8, 2020
Copy link
Contributor

@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, looks reasonable.

Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Deferring to OT-WG to merge

@bors
Copy link
Contributor

bors bot commented May 14, 2020

✌️ alistair23 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@alistair23
Copy link
Contributor Author

bors r+

@bors bors bot merged commit 2cec13d into tock:master May 14, 2020
@alistair23 alistair23 deleted the alistair/hmac-irq branch May 14, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants