kernel: move restart logic to function #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
May 8, 2020
hudson-ayers
approved these changes
May 11, 2020
ppannuto
reviewed
May 11, 2020
| /// | ||
| /// After `restart()` runs the process will either be queued to run its | ||
| /// `_start` function, or it will be left in `failure_state`. | ||
| fn restart(&self, failure_state: State) { |
There was a problem hiding this comment.
Since restarting can fail, should the function return some indication of success or failure?
There was a problem hiding this comment.
I'm not sure. I have no idea what the caller could do with that information, but it might be useful to know what happened and potentially report it back for informative purposes.
But, I think it's better if this PR doesn't change any behavior, just re-organizes code. Actual changes can be part of a different patch.
There was a problem hiding this comment.
I think if these was a pub I'd push back, but given that it's contained, this is fine for now.
|
bors r+ |
|
Timed out. |
|
bors retry |
|
Timed out. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request moves the process restart logic to its own function. This is a bit cleaner, but really it structures things more effectively for adding an
exitsyscall that can also be used to ask the kernel to restart the process.This is just a small refactor and doesn't change any current behavior.
I also updated some comments to make them more clear.
Testing Strategy
This pull request was tested by running the MPU fault test app and verifying that the app restarts several times on hail before the kernel panics.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.