Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to QEMU Make step #1866

Merged
merged 3 commits into from May 19, 2020
Merged

Conversation

alistair23
Copy link
Contributor

Pull Request Overview

This PR addresses concerns raised in: #1865

Testing Strategy

Pushed to Git.

TODO or Help Wanted

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make format.
  • Fixed errors surfaced by make clippy.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

I think these are strictly improvements over what we have. From the other PRs/Issues there might be more to do here, but let's take the easy stuff in now.

@bors bors bot merged commit fe7b44f into tock:master May 19, 2020
@alistair23 alistair23 deleted the alistair/qemu-fixes branch May 19, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants