apollo3: uart: Fix the UART callback #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hudson-ayers
previously approved these changes
Jun 1, 2020
alistair23
force-pushed
the
alistair/apollo3-uart
branch
from
6cc9a9c
to
caa3954
Compare
|
Why not call the callback instead of calling |
alistair23
force-pushed
the
alistair/apollo3-uart
branch
from
caa3954
to
51fc1ea
Compare
|
I think this might be wrong. We weren't clearing the interrupt. I have pushed an update that should fix it as well. |
bradjc
previously approved these changes
Jun 2, 2020
alistair23
force-pushed
the
alistair/apollo3-uart
branch
2 times, most recently
from
fa2cff8
to
f63e425
Compare
Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
force-pushed
the
alistair/apollo3-uart
branch
from
f63e425
to
6f67dbd
Compare
|
I pushed an update that fixes some other issues as well. |
bradjc
approved these changes
Jun 3, 2020
hudson-ayers
approved these changes
Jun 3, 2020
bors bot
added a commit
that referenced
this pull request
Jun 12, 2020
1897: Apollo3: Add support for the I2C device r=bradjc a=alistair23 ### Pull Request Overview This PR adds I2C support to the RedBoard Artemis Nano and the Apollo3 chip. This PR applies on top of ~~#1896 and #1889 #1899 ### Testing Strategy Monitoring the I2C traffic on the boards Qwiic connector. ### TODO or Help Wanted ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make format`. - [X] Fixed errors surfaced by `make clippy`. Co-authored-by: Alistair Francis <alistair@alistair23.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Fixes the UART callback for short strings.
Testing Strategy
Running on the RedBoard Artemis Nano.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make format.make clippy.