sam4l: usb: don't just queue resume in #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no idea why this was written this way
brghena
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
I'm convinced this was an oversight to not be here.
There is a crazy amount of indirection going on with endpoint states that makes this pretty hard to follow. But I'm pretty sure that if you are ready to resume the endpoint, there's no reason for it to sit around in the Delay state anymore. Moreover, that this solves the problem in practice convinces me.
brghena
requested changes
Jun 4, 2020
|
My opinion is that there seems like some unnecessary design choices in the SAM4L USB stack. However, since we're more focused on the nRF platforms in the long run, doing little things to get the SAM4L working in mostly in its current state seems good. |
Co-authored-by: Branden Ghena <brghena@berkeley.edu>
brghena
approved these changes
Jun 4, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
While working on #1048 #1893, getting UART.tx to work (sending from device to host) I noticed that transmissions only worked when a character was received. I tracked it down to this change.
Basically, we want to ask the host to send by asking to resume the IN endpoint. The SAM4L driver handled our request, but then queued it until some later event (hence why it didn't work until some receive event). With this change the SAM4L driver now immediately handles our resume in request.
I'm not sure why it was queued in the first place.
Testing Strategy
This pull request was tested by using hello_loop and console_recv apps on imix with the CDC driver.
TODO or Help Wanted
What am I missing? What was the queue for? Maybe this change is good enough since I don't know how much interest there is in debugging the SAM4L USB stack.
Documentation Updated
/docs, or no updates are required.Formatting
make format.make clippy.