Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf52: usb: correct register matching #1903

Merged
merged 2 commits into from Jun 4, 2020
Merged

nrf52: usb: correct register matching #1903

merged 2 commits into from Jun 4, 2020

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jun 2, 2020

Pull Request Overview

Allow endpoints greater than 2 to be enabled on nrf.

Found while working on CDC over UART.

Testing Strategy

Verifying CDC over UART works on nRF52.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make format.
  • Fixed errors surfaced by make clippy.

@bradjc bradjc added bug nrf Change pertains to the nRF5x family of MCUs. labels Jun 2, 2020
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the same error that occurs around lines 998, 1074, and 1086

@bradjc
Copy link
Contributor Author

bradjc commented Jun 3, 2020

Done, nice catch.

Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@hudson-ayers
Copy link
Contributor

I don't think bors can merge while @brghena review is still requesting changes

@brghena
Copy link
Contributor

brghena commented Jun 4, 2020

bors r+

@bors bors bot merged commit 134a288 into master Jun 4, 2020
@bors bors bot deleted the nrf52-usb-enum branch June 4, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nrf Change pertains to the nRF5x family of MCUs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants