Add Nano 33 BLE Board #1909
Merged
Add Nano 33 BLE Board #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
previously approved these changes
Jun 4, 2020
hudson-ayers
previously approved these changes
Jun 4, 2020
hudson-ayers
previously approved these changes
Jun 9, 2020
brghena
reviewed
Jun 13, 2020
brghena
added
the
blocked
brghena
removed
the
blocked
brghena
reviewed
Jun 19, 2020
Comment on lines
+28
to
+46
| fn write(&mut self, buf: &[u8]) { | ||
| let uart = unsafe { &mut nrf52840::uart::UARTE0 }; | ||
| if !self.initialized { | ||
| self.initialized = true; | ||
| uart.configure(uart::Parameters { | ||
| baud_rate: 115200, | ||
| stop_bits: uart::StopBits::One, | ||
| parity: uart::Parity::None, | ||
| hw_flow_control: false, | ||
| width: uart::Width::Eight, | ||
| }); | ||
| } | ||
| for &c in buf { | ||
| unsafe { | ||
| uart.send_byte(c); | ||
| } | ||
| while !uart.tx_ready() {} | ||
| } | ||
| } |
There was a problem hiding this comment.
How hard would it be to have the panic dump print out over USB instead of UART (or in addition)?
There was a problem hiding this comment.
Really hard, maybe impossible? I don't know how to do it without interrupts.
It might be worth thinking about handling panics in apps differently so that the kernel is still running while the panic message is printed.
There was a problem hiding this comment.
I won't block this PR on it, but we're going to have to think of some way to at least be able to debug crashing apps over USB serial if we want this to be a first-class board.
brghena
previously approved these changes
Jun 22, 2020
The GPIO numbers now match what is written on the board.
Co-authored-by: Branden Ghena <brghena@berkeley.edu>
brghena
approved these changes
Jun 24, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a board main.rs for the long-discussed (see #994) Nano 33 BLE board. Since it is based on the nrf52840, this is pretty straightforward.
The bootloader situation is not the best at the moment, but that is a work in progress. Also right now the UART requires attaching an FTDI chip to the UART pins. However, when the CDC USB stack is merged we can switch to using the USB header.
Testing Strategy
This pull request was tested by running the hello loop and blink apps on the board.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.