hil: ble_advertising: Pass the transmit buffer on callback #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Francis <alistair@alistair23.me>
bradjc
approved these changes
Jun 8, 2020
|
I tested this on the nrf52840dk with the libtock-c ble_advertising example and it works. One downside of this is that if a transmission fails for some reason the buffer is lost forever, whereas the previous design could just call |
bradjc
added
HIL
2 tasks
bors bot
added a commit
that referenced
this pull request
Jun 25, 2020
1934: Initial support for Apollo3 BLE r=bradjc a=alistair23 ### Pull Request Overview This PR adds initial support for the Apollo3 BLE module. This PR can power up the module and write data to it and receive interrupts. ~~This PR applies on top of: #1917 ### Testing Strategy Try to run the `libtock-c` examples on the Apollo3. ### TODO or Help Wanted Lots of things still aren't done, if anyone is willing to help I would be very grateful. BLE still doesn't work (I can't see the device advertise itself from other devices). This PR also doesn't apply the binaries (called patches) that are required to use the BLE module. I have a branch where I call the to HAL's C code to do this. I currently just see the `ble_advertisment_driver` alarm firing and the same data being written to the BLE device over and over again. I'm not sure what else should be happening, but BLE is currently not working. ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <alistair@alistair23.me> Co-authored-by: Brad Campbell <bradjc5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Pass the BLE transmit buffer back to the capsule.
Testing Strategy
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.