Import changes in kernel/src/common/utils.rs from #1618. #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
approved these changes
Jun 9, 2020
hudson-ayers
approved these changes
Jun 9, 2020
2 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a new
static_buf!macros and related types, as previously discussed in #1618 and agreed upon in #1618 (comment).This essentially imports the changes in
kernel/src/common/utils.rsfrom #1618, as well as the necessary rebasing of the code.Changes to the components themselves should further be discussed and agreed upon in #1618, and then a separate pull request (or multiple PRs) can migrate the code to new components.
Testing Strategy
This pull request was tested by CI.
TODO or Help Wanted
N/A - This part was extensively discussed in #1618.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.