New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many updates to comments in capsules/ #1927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
@hudson-ayers I made capsules their own CI job. There's no reason to run the kernel tests if you're debugging a failing capsule test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Unclear to me what currently makes the CI jobs fail.
bors r+ Looks an awful lot like infra failure ( 👎 ) on github actions; the next step never triggered and timed out... I just told all the CI to re-run. Assuming it passes, this should go through. |
#1935 I think explains why the qemu CI is failing. |
Pull Request Overview
This pull request cherry picks the comment/test updates from #1512. These are useful even if we can't fully run the tests automatically.
Testing Strategy
n/a
TODO or Help Wanted
n/a
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.