Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add core notes 2020-06-12 #1929

Merged
merged 1 commit into from Jun 15, 2020
Merged

add core notes 2020-06-12 #1929

merged 1 commit into from Jun 15, 2020

Conversation

hudson-ayers
Copy link
Contributor

Pull Request Overview

This pull request adds notes from todays core wg meeting. Hopefully I represented everything correctly, there was a good amount of fast-paced discussion that was pretty technical.

Testing Strategy

N/A

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs

Formatting

  • Ran make prepush.

@hudson-ayers hudson-ayers mentioned this pull request Jun 12, 2020
Closed
ppannuto
ppannuto approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link
Contributor

bors bot commented Jun 14, 2020

✌️ hudson-ayers can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@hudson-ayers
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 14, 2020

Build failed:

@ppannuto
Copy link
Member

bors retry

gendx
gendx reviewed Jun 15, 2020
View reviewed changes
doc/wg/core/notes/core-2020-06-12.md
Comment on lines +210 to +211
* Leon: I have another approach, Can I open a PR with this other approach so
we can compare them both
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lschuermann please go ahead if you have some draft PR to experiment with this, and/or some design sketch to share on #1905! On my side, I likely won't have time to work on a PR proposal this week.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll see what I can do, I don't know whether I'll make it this week either. Given that our proposals have only minor technical differences (from what I see the difference manifests itself rather in the usage semantics), if you have any idea for implementing i.e. the core kernel-held allow-table efficiently, I'd love to chat about that (e.g. on Slack).

@bors
Copy link
Contributor

bors bot commented Jun 15, 2020

Build succeeded:

@bors bors bot merged commit 555b3a0 into tock:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gendx gendx gendx left review comments

@lschuermann lschuermann lschuermann approved these changes

@brghena brghena brghena approved these changes

@ppannuto ppannuto ppannuto approved these changes

@jrvanwhy jrvanwhy jrvanwhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hudson-ayers @ppannuto @brghena @jrvanwhy @gendx @lschuermann