Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rv32i: fix PMP configuration #1932

Closed
wants to merge 2 commits into from
Closed

rv32i: fix PMP configuration #1932

wants to merge 2 commits into from

Conversation

a-pronin
Copy link
Contributor

This patch fixes how PMP registers are configured beyond the first two
regions (which occupy 4 blocks in pmpcfg0 - each unaligned region taking
two blocks). After that, the offsets & values used for pmpcfg1..3 were
often incorrect.

@a-pronin
rv32i: fix PMP configuration
95bd48f 
This change fixes how PMP registers are configured beyond the first two
regions (which occupy 4 blocks in pmpcfg0 - each unaligned region taking
two blocks). After that, the offsets & values used for pmpcfg1..3 were
often incorrect.

Change-Id: I10221f982515a6d63e75123e5f80f7a4d0468823
@a-pronin
Copy link
Contributor Author

Actually, conflicts with #1926. Given other changes, probably makes sense to wait for 1926, but need to fix the same things there.

@a-pronin a-pronin mentioned this pull request Jun 13, 2020
Merged
2 tasks
@bradjc bradjc added the blocked Waiting on something, like a different PR or a dependency. label Jun 15, 2020
alistair23
alistair23 previously approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@alistair23 alistair23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this all looks good to me. Do you mind rebasing it on master?

@hudson-ayers hudson-ayers removed the blocked Waiting on something, like a different PR or a dependency. label Jun 17, 2020
@bradjc bradjc added needs-rebase WG-OpenTitan In the purview of the OpenTitan working group. labels Jun 18, 2020
@a-pronin
Copy link
Contributor Author

I don't seem to be able to properly rebase this PR on top of recent changes. Besides, more problems discovered in PMP configuration after recent refactoring.
I give up, #1969 is filed instead (and a couple of less critical fixes/improvement to follow).

@bradjc bradjc closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 left review comments

Assignees
No one assigned
Labels
needs-rebase WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a-pronin @alistair23 @bradjc @hudson-ayers