nrf52: usb: do not print debug!() info on startup #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conflicts with using the USB stack for UART/debug!(), since those debug outputs cause the USB driver to try to start sending before it is fully initalized. Eventually, an assertion fails and everything crashes. They are also a little noisy for users not debugging the USB stack.
brghena
approved these changes
Jun 16, 2020
|
Disabling debug in the USB stack by default seems good. bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug statements at the beginning of the USB driver init process conflict with using the USB stack for UART/debug!(), since those debug outputs cause the USB driver to try to start sending before it is fully initialized. Eventually, an assertion fails and everything crashes.
They are also a little noisy for users not debugging the USB stack.
Testing Strategy
This pull request was tested by getting CDC working on the nano33ble board.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.