Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USB CDC Component, Move set_client() to USB HIL #1946

Merged
merged 3 commits into from Jun 18, 2020
Merged

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jun 16, 2020

Pull Request Overview

This pull request adds a CDC component, while also doing the standard update to the USB HIL to add set_client() to the interface.

Testing Strategy

This pull request was tested by running the CDC component on nano33ble.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

hudson-ayers
hudson-ayers previously approved these changes Jun 16, 2020
boards/components/src/cdc.rs Outdated Show resolved Hide resolved
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link
Contributor

bors bot commented Jun 16, 2020

✌️ bradjc can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bradjc bradjc added the last-call Final review period for a pull request. label Jun 17, 2020
@bradjc
Copy link
Contributor Author

bradjc commented Jun 18, 2020

bors r+

@bors bors bot merged commit a8a389d into master Jun 18, 2020
@bors bors bot deleted the component-cdc branch June 18, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call Final review period for a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants