Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate launchxl, cc26x2 #1963

Merged
merged 2 commits into from Jun 25, 2020
Merged

deprecate launchxl, cc26x2 #1963

merged 2 commits into from Jun 25, 2020

Conversation

ppannuto
Copy link
Member

Pull Request Overview

This pull request deprecates the LaunchXL and CC26x2, moving them to tock-archive.

This is not intended as a statement one way or another on this chip or board, rather just a recognition that this board has not seem much uptake, and maintenance is lagging (e.g. #1101).

See the companion PR here: tock/tock-archive#2

Testing Strategy

Compiling.

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Moved to tock-archive
hudson-ayers
hudson-ayers previously approved these changes Jun 19, 2020
alistair23
alistair23 previously approved these changes Jun 19, 2020
Copy link
Contributor

@alistair23 alistair23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Tock have a deprecation policy?

@bradjc
Copy link
Contributor

bradjc commented Jun 19, 2020

We have https://github.com/tock/tock/blob/master/doc/Design.md#merge-aggressively-archive-unabashedly

bradjc
bradjc previously approved these changes Jun 19, 2020
@ppannuto
Copy link
Member Author

We also talked about archiving this board during the 1.5 release window, then just didn't get around to actually doing it after the release.

@hudson-ayers
Copy link
Contributor

whoops, the benchmarks action fails if you remove a board, because it builds it for current master and then finds nothing to compare it to. It won't block merging though as it is not a required status.

@bradjc bradjc added the last-call Final review period for a pull request. label Jun 24, 2020
@bradjc
Copy link
Contributor

bradjc commented Jun 24, 2020

@tock/core-wg

brghena
brghena previously approved these changes Jun 24, 2020
niklasad1
niklasad1 previously approved these changes Jun 25, 2020
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like the benchmark fails because it tries to diff a previous board to a removed board AFAIU.

The script could check that both boards exist (in master and the current branch) otherwise ignore it but it doesn't have to be fixed in this PR though.

@bradjc bradjc dismissed stale reviews from niklasad1, brghena, alistair23, hudson-ayers, and themself via cf3f592 June 25, 2020 14:29
@bradjc
Copy link
Contributor

bradjc commented Jun 25, 2020

bors r+

@bors bors bot merged commit 079f44a into master Jun 25, 2020
@bors bors bot deleted the deprecate-launchxl branch June 25, 2020 14:44
@andresblanco06
Copy link

I am interested in developing on the CC26xx and CC13xx platform. Are there instruction on getting it work?

@hudson-ayers
Copy link
Contributor

There are instructions here, though you will be running an older version of Tock: https://github.com/tock/tock-archive/blob/bcb4e3872dd921ff42b3b8053815e969287d269b/launchxl/README.md .

In order to get flashing to work, you will likely need to follow the instructions here: https://github.com/tock/tock-archive/tree/bcb4e3872dd921ff42b3b8053815e969287d269b/launchxl/boards/launchxl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call Final review period for a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants