hil: gpio: remove 'static #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ppannuto
previously approved these changes
Jun 22, 2020
There was a problem hiding this comment.
bors d+
I think this one will unfortunately conflict with at least #1760 and any other new board / capsule PRs in flight, but there's probably never going to be a great window to get this in, and it's easy enough to add lifetimes to the other PRs
|
✌️ bradjc can now approve this pull request. To approve and merge a pull request, simply reply with |
bradjc
force-pushed
the
hil-no-static-gpio
branch
from
b019d3b
to
ad39870
Compare
hudson-ayers
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Part of #1074.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.