Stm32f4 I2C HAL #1968
Merged
Stm32f4 I2C HAL #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
reviewed
Jun 22, 2020
bradjc
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds the I2C HAL for the stm32f4xx chip.
The implementation is without DMA as the I2C overlaps with SPI and USART. The DMA HAL should be rewritten to allocate the streams on a need basis.
Testing Strategy
This pull request was tested using an stm32f412g discovery kit.
TODO or Help Wanted
Testing on other devices would be useful.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.