tools: pick toolchain that has all our components #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
force-pushed
the
rustup-component-aware
branch
from
0f1fe04
to
6d032a6
Compare
alistair23
approved these changes
Jun 23, 2020
|
Why do we need to specify rustc, rust-std, and cargo, rust-docs, rustfmt, and clippy? Those are included in the default rustup profile. |
|
I felt like the goal of this script was to automate things. What's included in the default rustup profile could change over time. I believe this is the list of the components we are actually using -- even if default rustup drops them, we still need them. It doesn't hurt to re-specify them I don't think. |
bradjc
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request uses rustup to automatically pick a toolchain that has all the components we need.
Testing Strategy
Not.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.