Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LowRISC: Initial commit of Pad Controller #1981

Merged
merged 3 commits into from Jun 29, 2020
Merged

LowRISC: Initial commit of Pad Controller #1981

merged 3 commits into from Jun 29, 2020

Conversation

alistair23
Copy link
Contributor

Pull Request Overview

This PR adds support for the Pad Controller to the GPIO device.

Testing Strategy

Booting Tock on the OT FPGA.

TODO or Help Wanted

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@alistair23 alistair23 added the WG-OpenTitan In the purview of the OpenTitan working group. label Jun 25, 2020
ppannuto
ppannuto previously approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I think this is good as-is, but I'd also be happier if you had a moment and wanted to just remove all the local regs variables.

chips/lowrisc/src/gpio.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Jun 26, 2020

✌️ alistair23 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@alistair23
chips: lowrisc: Add support for the Pad Ctrl registers
34e8709 
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23
chips: lowrisc: gpio: Allow setting the floating state
3e88460 
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23
chips: lowrisc: gpio: Remove the regs local variable
a10d0c5 
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23
Copy link
Contributor Author

bors r+

@ppannuto
Copy link
Member

bors retry

hudson-ayers
hudson-ayers approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors will fail unless there is "an approval from at least 1 reviewer with write access to the repository"

@bors
Copy link
Contributor

bors bot commented Jun 29, 2020

Build succeeded:

@bors bors bot merged commit 57f8a12 into tock:master Jun 29, 2020
@alistair23 alistair23 deleted the alistair/padctrl branch June 29, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson-ayers hudson-ayers hudson-ayers approved these changes

@ppannuto ppannuto ppannuto left review comments

Assignees
No one assigned
Labels
WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alistair23 @ppannuto @hudson-ayers