USB: CDC: Allow boards to specify vendor id, product id, and strings. #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use serial number from the chip for USB.
alevy
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Rather than hardcoding the USB identifying information, this allows the board file to set it for the board.
This adds a get address function for the nRF52, which permits using the hardcoded mac address as the serial number for USB so that USB devices get their own serial numbers.
This also configures the nano33ble to use the arduino vendor/product id that matches the bootloader. I think this makes sense for two reasons:
Testing Strategy
Running
lsusbafter flashing the kernel.TODO or Help Wanted
If someone wants to re-write
address_str().Documentation Updated
/docs, or no updates are required.Formatting
make prepush.