Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel::hil: time: fixed wrong implementation of is_oneshot() #2025

Merged
merged 1 commit into from Jul 15, 2020
Merged

kernel::hil: time: fixed wrong implementation of is_oneshot() #2025

merged 1 commit into from Jul 15, 2020

Conversation

lebakassemmerl
Copy link
Contributor

@lebakassemmerl lebakassemmerl commented Jul 15, 2020 •
edited

Pull Request Overview

This PR fixes the implementation of the function is_oneshot() in the Timer trait. By the definition the function interval() can return None if the timer is disabled OR in oneshot, thus it's not sufficient to only check if interval() returns None, its also necessary to check if the timer is enabled.

Testing Strategy

First an issue was opened, and the solution was confirmed there.

TODO or Help Wanted

x

Documentation Updated

x

Formatting

  • Ran ci-nosetup.

@hudson-ayers hudson-ayers linked an issue Jul 15, 2020 that may be closed by this pull request
Incorrect implementation of is_oneshot() in trait Timer in kernel::hil::time #2018
Closed
@bradjc
Copy link
Contributor

bradjc commented Jul 15, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 15, 2020

Build succeeded:

@bors bors bot merged commit 93be8ba into tock:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradjc bradjc bradjc approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect implementation of is_oneshot() in trait Timer in kernel::hil::time
3 participants
@lebakassemmerl @bradjc @hudson-ayers