Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sifive: uart: make sure tx enabled #2033

Merged
merged 1 commit into from Jul 20, 2020
Merged

sifive: uart: make sure tx enabled #2033

merged 1 commit into from Jul 20, 2020

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jul 17, 2020

Pull Request Overview

This pull request makes sure that the UART is enabled during panic printing on sifive platforms.

Testing Strategy

Causing the arty-e21 board to panic.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

ppannuto
ppannuto approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 20, 2020

Build succeeded:

@bors bors bot merged commit d11598f into master Jul 20, 2020
@bors bors bot deleted the sifive-uart-enable-tx branch July 20, 2020 13:40
@jrvanwhy jrvanwhy mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@ppannuto ppannuto ppannuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bradjc @alistair23 @ppannuto