Ft6x06 touch status fix and impoved report efficency #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandruradovici
changed the title
hudson-ayers
reviewed
Aug 5, 2020
capsules/src/touch.rs
Outdated
| @@ -41,6 +43,9 @@ impl Default for App { | |||
| events_buffer: None, | |||
| ack: true, | |||
| dropped_events: 0, | |||
| x: 0, | |||
| y: 0, | |||
| status: 3, | |||
There was a problem hiding this comment.
Could status be changed to be a TouchStatus type, and an Unstarted variant added to TouchStatus? I find this initialization to 3 confusing and prone to breakage in the future if additional variants are added to TouchStatus.
There was a problem hiding this comment.
Done, thank you for the tip.
hudson-ayers
approved these changes
Aug 5, 2020
|
Hey, any updates on merging this? |
|
bors r+ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes a bug in ft6x06 when reporting the touch status. It also reports touches more efficiently to the user land, scheduling a callback only when the position or status changes.
Testing Strategy
This pull request was tested using an stm32f412g discovery.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.