pmp: add PMP struct #2064
Merged
pmp: add PMP struct #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PMP wasn't working on the arty because the configure function wasn't actually iterating the PMP regions. This separates out the PMP from the config, and makes a lot more sense to me. And it works on the arty-e21 board.
hudson-ayers
previously approved these changes
Aug 5, 2020
alistair23
reviewed
Aug 11, 2020
Comment on lines
-142
to
+156
| pub struct PMPConfig<N: PMPConfigType> { | ||
| pub struct PMPConfig { |
There was a problem hiding this comment.
This change is fine, but just noting that it is moving us more towards the macro approach as we get further away from the array generators.
There was a problem hiding this comment.
For general awareness, the minimum subset of const generics that will be stabilized now has its own feature gate (rust-lang/rust#74877). Its not stable yet, but clearly on the fast track now.
alistair23
reviewed
Aug 11, 2020
arch/rv32i/src/pmp.rs
Outdated
| fn default() -> Self { | ||
| PMPConfig { | ||
| regions: [None; $x / 2], | ||
| is_dirty: Cell::new(true), | ||
| last_configured_for: MapCell::empty(), | ||
|
|
There was a problem hiding this comment.
There is an extra new line here
alistair23
previously approved these changes
Aug 11, 2020
bradjc
commented
Aug 13, 2020
hudson-ayers
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The PMP wasn't working on the arty because the configure function wasn't actually iterating the PMP regions. This separates out the PMP from the config, and makes a lot more sense to me. And it works on the arty-e21 board.
Testing Strategy
This pull request was tested by running on arty e21.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.