Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hifive1: Document required revb parameter for qemu #2065

Merged
merged 1 commit into from Aug 2, 2020
Merged

hifive1: Document required revb parameter for qemu #2065

merged 1 commit into from Aug 2, 2020

Conversation

lschuermann
Copy link
Member

@lschuermann lschuermann commented Aug 1, 2020 •
edited

Pull Request Overview

This pull request adds the required ,revb=true parameter for the QEMU command line when starting the HiFive1 emulated board. Otherwise it will simply not boot silently.

Testing Strategy

This pull request was tested by running the documented command line.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

ppannuto
ppannuto approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 2, 2020

Build succeeded:

@bors bors bot merged commit 167d17e into tock:master Aug 2, 2020
@lschuermann lschuermann deleted the dev/hifive1-revb-qemu-cli branch December 17, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@ppannuto ppannuto ppannuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lschuermann @alistair23 @ppannuto