OpenTitan: Add support for detecting the USB device #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
force-pushed
the
alistair/opentitan-usb
branch
from
a38a703
to
5bb035a
Compare
bradjc
previously approved these changes
Aug 27, 2020
|
Ping! |
phil-levis
requested changes
Sep 3, 2020
| .set(1 << endpoint | self.registers.stall.get()); | ||
| } | ||
|
|
||
| fn copy_slice_out_to_hw(&self, ep: usize, buf_id: usize, size: usize) { |
There was a problem hiding this comment.
This should use enumerations rather than usize, for ep and buf_id, to allow compile-time rather than runtime checking.
There was a problem hiding this comment.
That would required converting from the uszie from the HIL to a enum, what advantage does that give us? It is then written to the hardware as just a number.
| ); | ||
| } | ||
|
|
||
| fn copy_from_hw(&self, ep: usize, buf_id: usize, size: usize) { |
There was a problem hiding this comment.
Same as copy_slice_out_to_hw.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Commit the freed buffers after they are freed. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/opentitan-usb
branch
from
5bb035a
to
fa5161e
Compare
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/opentitan-usb
branch
from
217c567
to
5bfcadd
Compare
|
Ping! |
phil-levis
approved these changes
Sep 10, 2020
|
bors r+ |
1 similar comment
|
bors r+ |
|
Already running a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This allows me to see the OpenTitan USB device when running Tock.
There still seems to be some timing issues and the device doesn't always appear, but at least this is better then the current nothing.
Testing Strategy
Plugging in the OpenTitan FPGA.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.