Earlgrey: dont call debug in interrupt top half #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with removing debug!() from a safety standpoint, but do we need to panic!()? |
alistair23
approved these changes
Sep 25, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request replaces calls to
debug!()in the top half interrupt handler for theearlgreychip withpanic!(). If these calls executed it could cause UB, as the Tock kernel assumes that kernel code is not reentrant, anddebug!()calls UART code.I came across this while symbolically executing interrupt handlers in Tock.
Testing Strategy
N/A
TODO or Help Wanted
How bad is the possibility of a reentrant panic that this in theory could introduce?
Documentation Updated
Formatting
make prepush.