fix rustdoc CI, force bash for Makefile.common #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
Sep 25, 2020
ppannuto
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes #2124 by uniting
boards/Makefile.commonandMakefilesuch thatbashis the default shell for both. This fixes an issue where whenMakefile.commonwas called by a shell script from theMakefileon the ubuntu CI machine, it would use the default ubuntu shelldashwhich does not support the syntax used to detect warnings in rustdoc.Testing Strategy
This pull request was tested by running the CI locally on Ubuntu 20.04 before and after this change.
TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.