Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all uses of unstable const_in_array_repeat_expressions feature #2215

Merged
merged 1 commit into from
Dec 2, 2020
Merged

remove all uses of unstable const_in_array_repeat_expressions feature #2215

merged 1 commit into from
Dec 2, 2020

Conversation

hudson-ayers
Copy link
Contributor

Pull Request Overview

This pull request removes all uses of the unstable const_in_array_repeat_expressions feature. It was originally necessary in order to have ergonomic scheduler components, but a subset of the feature that is sufficient for our use was accidentally stabilized, and the Rust maintainers are moving to make that stabilization permanent (see rust-lang/rust#79270). So this is an easy way to get rid of an unstable feature.

Testing Strategy

This pull request was tested by compiling and flashing several apps on an Imix.

TODO or Help Wanted

N/A

Documentation Updated

  • No updates are required.

Formatting

  • Ran make prepush.

@hudson-ayers hudson-ayers mentioned this pull request Nov 23, 2020
Open
29 tasks
lschuermann
lschuermann approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the Rust PR it seems like this is only a proposal to acknowledge that [CONST; N] is stable, not a commitment. Nonetheless this change can't hurt and it seems much closer to stable (well, actually is) than const_in_array_repeat_expression.

@hudson-ayers hudson-ayers added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Nov 24, 2020
@bradjc
Copy link
Contributor

bradjc commented Dec 2, 2020

bors r+

1 similar comment
@bradjc
Copy link
Contributor

bradjc commented Dec 2, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 2, 2020

Build succeeded:

@bors bors bot merged commit b939473 into tock:master Dec 2, 2020
@hudson-ayers hudson-ayers mentioned this pull request Dec 19, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@bradjc bradjc bradjc approved these changes

@lschuermann lschuermann lschuermann approved these changes

Assignees
No one assigned
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hudson-ayers @bradjc @alistair23 @lschuermann