Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update touch and ft60x6 drivers to Tock 2.0 #2258

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

alexandruradovici
Copy link
Contributor

Pull Request Overview

This pull request updates the touch and ft60x6 drivers to Tock 2.0 syscalls.

It adds an is_set function to Callback to be able to determine if a callback has been set.

Testing Strategy

This pull request was tested using an STM32F412G Discovery board.

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@alexandruradovici alexandruradovici changed the title Update Touch and ft60x6 drivers syscall 2.0 Update Touch and ft60x6 drivers to Tock 2.0 Dec 11, 2020
@alexandruradovici alexandruradovici changed the title Update Touch and ft60x6 drivers to Tock 2.0 Update touch and ft60x6 drivers to Tock 2.0 Dec 11, 2020
@bradjc bradjc added the tock-2.0 Issues and PRs related to Tock version 2.0. label Dec 11, 2020
Copy link
Contributor

@phil-levis phil-levis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want a Callback::is_set, but want to understand your use case better to be sure.

kernel/src/callback.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit cc154b6 into tock:tock-2.0-dev Dec 21, 2020
@hudson-ayers hudson-ayers mentioned this pull request Mar 9, 2021
18 tasks
lschuermann pushed a commit to lschuermann/tock that referenced this pull request Mar 20, 2021
2258: Update touch and ft60x6 drivers to Tock 2.0 r=hudson-ayers a=alexandruradovici

### Pull Request Overview

This pull request updates the `touch` and `ft60x6` drivers to Tock 2.0 syscalls.

It adds an `is_set` function to `Callback` to be able to determine if a callback has been set.


### Testing Strategy

This pull request was tested using an STM32F412G Discovery board.

### TODO or Help Wanted

N/A

### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make prepush`.


Co-authored-by: Alexandru Radovici <msg4alex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tock-2.0 Issues and PRs related to Tock version 2.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants