-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update touch and ft60x6 drivers to Tock 2.0 #2258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandruradovici
changed the title
Update Touch and ft60x6 drivers syscall 2.0
Update Touch and ft60x6 drivers to Tock 2.0
Dec 11, 2020
alexandruradovici
changed the title
Update Touch and ft60x6 drivers to Tock 2.0
Update touch and ft60x6 drivers to Tock 2.0
Dec 11, 2020
phil-levis
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want a Callback::is_set, but want to understand your use case better to be sure.
2 tasks
alexandruradovici
force-pushed
the
tock-2.0_touch
branch
from
December 18, 2020 10:50
64985be
to
d79661d
Compare
phil-levis
approved these changes
Dec 18, 2020
hudson-ayers
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
2 tasks
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2258: Update touch and ft60x6 drivers to Tock 2.0 r=hudson-ayers a=alexandruradovici ### Pull Request Overview This pull request updates the `touch` and `ft60x6` drivers to Tock 2.0 syscalls. It adds an `is_set` function to `Callback` to be able to determine if a callback has been set. ### Testing Strategy This pull request was tested using an STM32F412G Discovery board. ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Alexandru Radovici <msg4alex@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the
touch
andft60x6
drivers to Tock 2.0 syscalls.It adds an
is_set
function toCallback
to be able to determine if a callback has been set.Testing Strategy
This pull request was tested using an STM32F412G Discovery board.
TODO or Help Wanted
N/A
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.