New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create core-notes-2021-10-29.md #2881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I missed one comment from Jett, but otherwise was able to catch everything; as always, refinements, fixes, edits appreciated — and apologies for anything I butchered :)
lschuermann
previously approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking the notes! Noticed some minor things while reading over it.
Co-authored-by: Leon Schuermann <leon@is.currently.online>
Co-authored-by: Leon Schuermann <leon@is.currently.online>
Co-authored-by: Leon Schuermann <leon@is.currently.online>
lschuermann
approved these changes
Oct 29, 2021
hudson-ayers
approved these changes
Nov 1, 2021
jrvanwhy
approved these changes
Nov 1, 2021
bors r+ |
1 similar comment
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
I think I missed one comment from Jett, but otherwise was able to catch everything; as always, refinements, fixes, edits appreciated — and apologies for anything I butchered :)
Testing Strategy
N/A
TODO or Help Wanted
N/A
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.