Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create core-notes-2021-10-29.md #2881

Merged
merged 4 commits into from Nov 17, 2021
Merged

Create core-notes-2021-10-29.md #2881

merged 4 commits into from Nov 17, 2021

Conversation

ppannuto
Copy link
Member

Pull Request Overview

I think I missed one comment from Jett, but otherwise was able to catch everything; as always, refinements, fixes, edits appreciated — and apologies for anything I butchered :)

Testing Strategy

N/A

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

I think I missed one comment from Jett, but otherwise was able to catch everything; as always, refinements, fixes, edits appreciated — and apologies for anything I butchered :)
lschuermann
lschuermann previously approved these changes Oct 29, 2021
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking the notes! Noticed some minor things while reading over it.

doc/wg/core/notes/core-notes-2021-10-29.md Outdated Show resolved Hide resolved
doc/wg/core/notes/core-notes-2021-10-29.md Outdated Show resolved Hide resolved
doc/wg/core/notes/core-notes-2021-10-29.md Outdated Show resolved Hide resolved
Co-authored-by: Leon Schuermann <leon@is.currently.online>
ppannuto and others added 2 commits October 29, 2021 12:50
Co-authored-by: Leon Schuermann <leon@is.currently.online>
Co-authored-by: Leon Schuermann <leon@is.currently.online>
@bradjc
Copy link
Contributor

bradjc commented Nov 16, 2021

bors r+

1 similar comment
@lschuermann
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 17, 2021

@bors bors bot merged commit 59ce1ac into master Nov 17, 2021
@bors bors bot deleted the ppannuto-patch-2 branch November 17, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants