process_console: Handle DEL char as backspace #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default on Linux the Backspace key outputs the DEL char Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
alexandruradovici
approved these changes
Feb 18, 2022
alistair23
approved these changes
Feb 20, 2022
ppannuto
approved these changes
Feb 22, 2022
hudson-ayers
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR intends to provide a fix to the handling of the BACKSPACE key when interfacing via serial port on Linux.
Currently, pressing the BACKSPACE key is a no-op, since the terminal outputs a
DELchar through the serial port, which is not handled by the Process Console.Testing Strategy
Tested with the ESP32-C3-DevKitM-1 development board under Ubuntu Linux 21.10. Verified that the BACKSPACE key now behaves as expected.
TODO or Help Wanted
Not applicable.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.