STM32f4xx: Properly support 4MHz SPI rate #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, setting 4MHz as the SPI rate was only supported in the rate setter, but not the getter.
LeonMatthesKDAB
force-pushed
the
spi-4MHz-rate
branch
from
9966c61
to
9488faa
Compare
alistair23
approved these changes
Apr 28, 2022
hudson-ayers
reviewed
May 3, 2022
|
I'll try and test it on an STM32F412g Discovery and an SPI display. |
bradjc
approved these changes
May 19, 2022
|
Fair enough. bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting 4MHz as the SPI rate was only supported in the
rate setter, but not the getter.
Pull Request Overview
This pull request adds support for 4MHz in the spi's set_rate and get_rate functions.
Previously, it was only supported in the set_rate function, but also wasn't documented!
Testing Strategy
I am currently not able to test this, I just stumbled across it whilst reading the SPI code.
Documentation Updated
Formatting
make prepush.